remove destroy_process_group() from finally wrapper as it can hang #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
lbluque
previously approved these changes
Oct 22, 2024
… into fix_distutils_cleanup
rayg1234
reviewed
Oct 23, 2024
| @@ -666,7 +666,9 @@ def run_relaxations(self, split="val"): | |||
| ) | |||
| gather_results["chunk_idx"] = np.cumsum( | |||
| [gather_results["chunk_idx"][i] for i in idx] | |||
| )[:-1] # np.split does not need last idx, assumes n-1:end | |||
| )[ | |||
| :-1 | |||
There was a problem hiding this comment.
this is really wierd linter formatting but 🤷
There was a problem hiding this comment.
That was the exact linting error... Also agree very weird, I think the IDE is injecting it sometimes
rayg1234
previously approved these changes
Oct 23, 2024
rayg1234
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroy_process_group() hangs and returns when a OOM CUDA error is raised internally. Instead of allowing the error to propagate it gets stuck in a never ending process and has a NCCL timeout.
Instead of calling destroy_process_group() when we know an exception already occurred, lets just crash out with the original exception.