Match escn_exportable with escn main #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayg1234
reviewed
Sep 19, 2024
| @@ -70,8 +70,8 @@ def load_model(type: str, compile=False, export=False): | |||
| cutoff=CUTOFF, | |||
| max_num_elements=MAX_ELEMENTS, | |||
| num_layers=8, | |||
| lmax_list=[4], | |||
| mmax_list=[2], | |||
| lmax_list=[6], | |||
There was a problem hiding this comment.
maybe leave a note here to mention some additional things we can add to make this test more sensitive: add backwards, add better weight initialization etc
|
Thanks for fixing this!! |
rayg1234
reviewed
Sep 19, 2024
| @@ -79,6 +79,7 @@ def __init__( | |||
| resolution: int | None = None, | |||
| compile: bool = False, | |||
| export: bool = False, | |||
| rescale_grid: bool = False, | |||
There was a problem hiding this comment.
unless we plan to test this, lets remove this as an option, i still prefer to remove the rescale code and keep it simpler
kyonofx
previously approved these changes
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
kyonofx
approved these changes
Sep 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix l/m; make rescaling optional