Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw error when metadata is non integer #865

Merged
merged 2 commits into from
Sep 19, 2024
Merged

throw error when metadata is non integer #865

merged 2 commits into from
Sep 19, 2024

Conversation

misko
Copy link
Collaborator

@misko misko commented Sep 18, 2024

No description provided.

@misko misko added enhancement New feature or request patch Patch version release labels Sep 18, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/fairchem/core/datasets/base_dataset.py 93.22% <100.00%> (+0.05%) ⬆️

@misko misko requested a review from rayg1234 September 19, 2024 20:34
@misko misko added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 6bd1888 Sep 19, 2024
8 checks passed
@misko misko deleted the throw_error_on_non_int_natoms_metadata branch September 19, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayg1234 rayg1234 rayg1234 approved these changes

@lbluque lbluque Awaiting requested review from lbluque

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misko @rayg1234