Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add act checkpointing to escn #852

Merged
merged 6 commits into from
Sep 24, 2024
Merged

add act checkpointing to escn #852

merged 6 commits into from
Sep 24, 2024

Conversation

misko
Copy link
Collaborator

@misko misko commented Sep 15, 2024

No description provided.

@misko misko requested a review from rayg1234 September 15, 2024 21:27
@misko misko added enhancement New feature or request patch Patch version release labels Sep 15, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/models/escn/escn.py 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/models/escn/escn.py 95.65% <85.71%> (-0.22%) ⬇️

... and 1 file with indirect coverage changes

rayg1234
rayg1234 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@rayg1234 rayg1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@misko misko added this pull request to the merge queue Sep 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 19, 2024
@misko misko requested a review from wood-b September 23, 2024 18:06
wood-b
wood-b approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@wood-b wood-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@misko misko added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 21a5ea2 Sep 24, 2024
8 checks passed
@misko misko deleted the add_activation_checkpointing_to_escn branch September 24, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wood-b wood-b wood-b approved these changes

@rayg1234 rayg1234 rayg1234 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misko @rayg1234 @wood-b