Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 line change, this is needed for activation checkpointing to work if we want the interface to remain passing SO3_embedding objects to the transformer. In normal operation the code is not wrong but error prone because the function modifies the input inplace, which the user does not expect. See https://fairwandb.org/fairchem/fm_testing/reports/Training-Instability-of-Large-EQV2-Models--Vmlldzo0MzI5NQ for more details
The alternative solution is to change the transformer.forward signature to take tensors instead but this introduces more breaking changes in the code