Merge pull request #369 from Eyevinn/stpp-type

stpp as value to CreateEmptyTrak
Eyevinn · Aug 8, 2024 · 5310a00 · 5310a00
2 parents 2d7724e + cf62a63
commit 5310a00
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Event Message boxes evte, emib, emeb
 - GetBtrt method to StsdBox
 - Btrt pointer attribute in AudioSampleEnntry
+- stpp can be used as value to CreateEmptyTrak
 
 ## [0.45.1] - 2024-07-12
 

diff --git a/mp4/initsegment.go b/mp4/initsegment.go
@@ -156,7 +156,7 @@ func CreateEmptyTrak(trackID, timeScale uint32, mediaType, language string) *Tra
 		minf.AddChild(CreateVmhd())
 	case "audio":
 		minf.AddChild(CreateSmhd())
-	case "subtitle", "subtitles":
+	case "subtitle", "subtitles", "stpp":
 		minf.AddChild(&SthdBox{})
 	case "text", "wvtt":
 		minf.AddChild(&NmhdBox{})

diff --git a/mp4/mediasegment.go b/mp4/mediasegment.go
@@ -10,7 +10,7 @@ import (
 // MediaSegment is an MP4 Media Segment with one or more Fragments.
 type MediaSegment struct {
 	Styp        *StypBox
-	Sidx        *SidxBox   // The fist sidx box in a segment
+	Sidx        *SidxBox   // The first sidx box in a segment
 	Sidxs       []*SidxBox // All sidx boxes in a segment
 	Fragments   []*Fragment
 	EncOptimize EncOptimize

diff --git a/mp4/trun.go b/mp4/trun.go
@@ -115,7 +115,8 @@ func DecodeTrunSR(hdr BoxHeader, startPos uint64, sr bits.SliceReader) (Box, err
 	return t, sr.AccError()
 }
 
-// CreateTrun - create a TrunBox for filling up with samples
+// CreateTrun - create a TrunBox for filling up with samples.
+// writeOrderNr is only used for multi-trun offsets.
 func CreateTrun(writeOrderNr uint32) *TrunBox {
 	trun := &TrunBox{
 		Version:          1,     // Signed composition_time_offset