[OUR415-314] Improves our test story with test templates and helpers for search; adds BrowserRefinementList component test
#259
Conversation
rosschapman
changed the title
rosschapman
changed the title
BrowserRefinementList component test
rosschapman
changed the title
BrowserRefinementList component testBrowserRefinementList component test
| import { createSearchClient } from "../../../../test/helpers/createSearchClient"; | ||
|
|
||
| describe("BrowseRefinementList", () => { | ||
| test("renders the correct the number of categories", async () => { |
There was a problem hiding this comment.
question (non-blocking): There are 12 categories in searchClient but expected is 10. Is there anything in the repo that explains this?
There was a problem hiding this comment.
Good question. I updated the test name to indicate more explicitly what this is testing.
| @@ -39,10 +39,12 @@ const BrowseRefinementList = ({ attribute, transform }: Props) => { | |||
| setChecked(checked); | |||
| }; | |||
|
|
|||
| // console.log(items); | |||
There was a problem hiding this comment.
chore: Let's get rid of this
| */ | ||
| export function createSearchClient(options: Options) { | ||
| return { | ||
| search: (requests: any) => |
There was a problem hiding this comment.
question (if-minor): In the interest of minimizing lint warnings, can we change these 2 'any' types in this file or can we lint ignore this file?
There was a problem hiding this comment.
Oops yeah, forgot to add ignore statements. I was going to clean up all the warnings in a separate PR so I can do it there.
| @@ -0,0 +1,25 @@ | |||
| /** | |||
| * Template for a simple component test | |||
There was a problem hiding this comment.
praise: Good idea
| import { createSearchClient } from "../../../../test/helpers/createSearchClient"; | ||
|
|
||
| describe("BrowseRefinementList", () => { | ||
| test("renders the correct the number of categories", async () => { |
There was a problem hiding this comment.
nitpick (non-blocking): Could you remove the second "the"?
I wrote our first component test of a component with Algolia hooks. This code establishes a precedent but as more tests are written we might come up with improvements to the "test harness" to increase ease of writing tests.