[OUR415-314] Fixes eligibility and category lists in Browse Experience #258
Conversation
| // Important to override react-burger-menu lib styles | ||
| display: flex !important; | ||
| flex-direction: column; | ||
| align-items: center; |
There was a problem hiding this comment.
note: We got rid of the react-burger-menu lib so these declarations are no longer necessary.
| @include r_max($break-tablet-s) { | ||
| width: calc(100vw - $general-spacing-xs); | ||
| } |
There was a problem hiding this comment.
note: This expands the top level category dropdown full width. Had not implemented it yet.
There was a problem hiding this comment.
Just wondering - Is there a reason for choosing general-spacing-xs? Or for adding that only on the category dropdown rather the nav dropdown too?
There was a problem hiding this comment.
Only that I discovered this variable defined the correct spacing.
| @@ -38,6 +38,7 @@ | |||
| align-self: flex-start; | |||
| border-right: 0; | |||
| background-color: #fff; | |||
| z-index: $z-index-filters-menu; | |||
There was a problem hiding this comment.
note: Discovered a bug where the filters were not on top.
There was a problem hiding this comment.
Speaking of z-indexes. The category dropdown appears to have a higher z-index than the navigation bar. If that would be a quick fix, might make sense to put it in this PR
There was a problem hiding this comment.
What browser/resolution is that? I don't even know how to get in that state 😅
| @@ -0,0 +1,20 @@ | |||
| import { faker } from "@faker-js/faker"; | |||
Also:
BrowseRefinementListtest, proving that tests are useful!