-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump algoliasearch from 5.2.5 to 5.10.1 #232
Bump algoliasearch from 5.2.5 to 5.10.1 #232
Conversation
9c3965f
to
2ea3ef5
Compare
2ea3ef5
to
6662e24
Compare
Bumps [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript) from 5.2.5 to 5.10.1. - [Release notes](https://github.com/algolia/algoliasearch-client-javascript/releases) - [Changelog](https://github.com/algolia/algoliasearch-client-javascript/blob/main/CHANGELOG.md) - [Commits](algolia/algoliasearch-client-javascript@5.2.5...5.10.1) --- updated-dependencies: - dependency-name: algoliasearch dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
6662e24
to
071577b
Compare
@@ -26,10 +26,10 @@ import { | |||
Service, | |||
} from "../../models"; | |||
import styles from "./ServiceListingPage.module.scss"; | |||
import { algoliasearch } from "algoliasearch"; | |||
import { searchClient } from "@algolia/client-search"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: This is lighter package for working just with search and index objects without bringing in other APIs for Recommend, Analytics, A/B testing, etc.... See: https://www.algolia.com/doc/libraries/javascript/v5/methods/search/.
However, we are still importing the larger complete algoliasearch
package. It's a bit of a longer story, but ideally I would just use the algoliasearch/lite
module everywhere. But there are some type issues emanating when using that for single record lookup with client.getObject
. These particular types errors were supposed to be fixed in v5.2.x. So strange we're seeing them:
ERROR in ./node_modules/algoliasearch/dist/browser.js 22:19-28
export 'EventType' (imported as 'EventType') was not found in '@algolia/client-personalization' (possible exports: apiClientVersion, personalizationClient)
@ ./app/pages/ServiceListingPage/ServiceListingPage.tsx 14:0-45 16:15-27
@ ./app/Router.tsx 9:0-81 54:62-80
@ ./app/components/ui/Navigation/Navigation.tsx 10:0-41 85:38-44
@ ./app/components/ui/index.ts 5:0-40 5:0-40
@ ./app/App.tsx 9:0-61 42:44-50 79:40-50 79:92-98
@ ./app/init.tsx 6:0-28 11:211-214
On top of that we actually only need avail ourselves of single record lookup with getObject
as a hack for service data that might be missing. So the algolia story is a little bit of a mess right now but I think over time we'll be able to figure out a solution using a single, leaner algolia search JS module. I'm just not going to worry about it too much at this moment.
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
A newer version of algoliasearch exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps algoliasearch from 5.2.5 to 5.10.1.
Release notes
Sourced from algoliasearch's releases.
... (truncated)
Changelog
Sourced from algoliasearch's changelog.
... (truncated)
Commits
4dc1011
chore: release 5.10.1a1b7c61
fix(javascript): common package types (generated)3d21c6a
chore: release 5.10.0b547e60
chore(javascript): build algoliasearch everytime (generated)3556e60
docs(analytics): constrain pagination only to limit query parameter (generated)0ba8856
fix(javascript): use unknown over any (generated)075602f
chore(deps): dependencies 2024-10-21 (generated)77c88d4
fix(javascript): do not publish ts (generated)c066b4d
feat(javascript): assert algoliasearch bundle (generated)55a5796
chore: release 5.9.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)