Set up configs and flows from Expensify repository template #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertKozik
force-pushed
the
merge-expensify-template
branch
from
bf2d6dc
to
303aee8
Compare
robertKozik
force-pushed
the
merge-expensify-template
branch
from
6b9bb47
to
9eaafec
Compare
robertKozik
force-pushed
the
merge-expensify-template
branch
from
58c72fc
to
1d0bcd8
Compare
robertKozik
force-pushed
the
merge-expensify-template
branch
from
20d3ad7
to
2e7c5d2
Compare
tomekzaw
reviewed
Jan 16, 2024
.eslintignore
Outdated
| @@ -1,2 +1,8 @@ | |||
| **/node_modules/* | |||
| parser/react-native-live-markdown-parser.js | |||
| **/react-native-live-markdown-parser.js | |||
There was a problem hiding this comment.
Why not parser/react-native-live-markdown-parser.js?
There was a problem hiding this comment.
Turns out react-native-live-markdown-parser.js can be found as well inside android subfolders.
But as we wawnt to setup eslints inside each folder, I'll exclude all files from parser as well (alongside every file js file from android and ios folder)
tomekzaw
reviewed
Jan 16, 2024
…om eslint ignore to enable ide highlights
tomekzaw
reviewed
Jan 17, 2024
| @@ -31,6 +31,10 @@ | |||
| "test": "jest", | |||
| "typecheck": "tsc --noEmit", | |||
| "lint": "eslint . --ext .js,.ts,.tsx", | |||
| "lint:root": "eslint . --ext .js,.ts,.tsx --ignore-pattern '/example/**/*' --ignore-pattern '/WebExample/**/*' --ignore-pattern '/parser/**/*'", | |||
There was a problem hiding this comment.
Can we move --ignore-pattern arguments from here to ignorePatterns option in .eslintrc.json?
There was a problem hiding this comment.
I think we cannot as we just want to ignore this directories while executing lint:root. If we would add it to ignorePatterns no errors would be visible in IDE on there directories
.eslintrc.js
Outdated
| '@typescript-eslint/no-var-requires': 'warn', | ||
| 'eqeqeq': 'error', | ||
| 'no-unreachable': 'error', | ||
|
|
tomekzaw
approved these changes
Jan 18, 2024
Merged
tomekzaw
added a commit
that referenced
this pull request
Feb 5, 2024
Co-authored-by: Tomek Zawadzki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.