-
Notifications
You must be signed in to change notification settings - Fork 60
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
introduce prettier/eslint configs and github flows from Expensify tem…
…plate
- Loading branch information
1 parent
e8cae9c
commit d968cad
Showing
15 changed files
with
1,123 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,7 @@ | ||
**/node_modules/* | ||
parser/react-native-live-markdown-parser.js | ||
**/react-native-live-markdown-parser.js | ||
*.test.* | ||
example/**/* | ||
*.config.js | ||
.eslintrc.js | ||
.prettierrc.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<!-- If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit. --> | ||
|
||
### Details | ||
<!-- Explanation of the change or anything fishy that is going on --> | ||
|
||
### Related Issues | ||
<!-- Please replace GH_LINK with the link to the GitHub issue this Pull Request is related to --> | ||
GH_LINK | ||
|
||
### Manual Tests | ||
<!--- | ||
Most changes should have accompanying tests. Describe the tests you added or if no tests were added an explanation about why one was not needed. | ||
---> | ||
|
||
### Linked PRs | ||
<!--- | ||
Please include links to any update PRs in repos that must change their package.json version. | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: CLA Assistant | ||
|
||
on: | ||
issue_comment: | ||
types: [created] | ||
pull_request_target: | ||
types: [opened, closed, synchronize] | ||
|
||
jobs: | ||
CLA: | ||
runs-on: ubuntu-latest | ||
# This job only runs for pull request comments or pull request target events (not issue comments) | ||
if: github.event.issue.pull_request || github.event_name == 'pull_request_target' | ||
steps: | ||
- uses: actions-ecosystem/action-regex-match@9c35fe9ac1840239939c59e5db8839422eed8a73 | ||
id: sign | ||
with: | ||
text: ${{ github.event.comment.body }} | ||
regex: '\s*I have read the CLA Document and I hereby sign the CLA\s*' | ||
- uses: actions-ecosystem/action-regex-match@9c35fe9ac1840239939c59e5db8839422eed8a73 | ||
id: recheck | ||
with: | ||
text: ${{ github.event.comment.body }} | ||
regex: '\s*recheck\s*' | ||
- name: CLA Assistant | ||
if: ${{ steps.recheck.outputs.match != '' || steps.sign.outputs.match != '' }} || github.event_name == 'pull_request_target' | ||
# Version: 2.1.2-beta | ||
uses: cla-assistant/github-action@948230deb0d44dd38957592f08c6bd934d96d0cf | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
PERSONAL_ACCESS_TOKEN : ${{ secrets.CLA_BOTIFY_TOKEN }} | ||
with: | ||
path-to-signatures: '${{ github.repository }}/cla.json' | ||
path-to-document: 'https://github.com/${{ github.repository }}/blob/main/CLA.md' | ||
branch: 'main' | ||
remote-organization-name: 'Expensify' | ||
remote-repository-name: 'CLA' | ||
lock-pullrequest-aftermerge: false | ||
allowlist: 'snyk-bot,OSBotify' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: Lint JavaScript | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize] | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- uses: actions/cache@v2 | ||
with: | ||
path: ~/.npm | ||
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
restore-keys: | | ||
${{ runner.os }}-node- | ||
- name: Setup Node | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: "16.x" | ||
|
||
- run: npm ci | ||
|
||
- run: npm run lint | ||
env: | ||
CI: true | ||
|
||
|
||
- name: Verify there's no Prettier diff | ||
run: | | ||
npm run prettier -- --loglevel silent | ||
if ! git diff --name-only --exit-code; then | ||
# shellcheck disable=SC2016 | ||
echo 'Error: Prettier diff detected! Please run `npm run prettier` and commit the changes.' | ||
exit 1 | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
# name: Publish package to npmjs | ||
|
||
# # This workflow runs when code is pushed to `main` (i.e: when a pull request is merged) | ||
# on: | ||
# push: | ||
# branches: [main] | ||
|
||
# # Ensure that only once instance of this workflow executes at a time. | ||
# # If multiple PRs are merged in quick succession, there will only ever be one publish workflow running and one pending. | ||
# concurrency: ${{ github.workflow }} | ||
|
||
# jobs: | ||
# version: | ||
# runs-on: ubuntu-latest | ||
|
||
# # OSBotify will update the version on `main`, so this check is important to prevent an infinite loop | ||
# if: ${{ github.actor != 'OSBotify' }} | ||
|
||
# steps: | ||
# - uses: actions/checkout@v3 | ||
# with: | ||
# ref: main | ||
|
||
# - name: Decrypt & Import OSBotify GPG key | ||
# run: | | ||
# cd .github | ||
# gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output OSBotify-private-key.asc OSBotify-private-key.asc.gpg | ||
# gpg --import OSBotify-private-key.asc | ||
# env: | ||
# LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} | ||
|
||
# - name: Set up git for OSBotify | ||
# run: | | ||
# git config --global user.signingkey 367811D53E34168C | ||
# git config --global commit.gpgsign true | ||
# git config --global user.name OSBotify | ||
# git config --global user.email [email protected] | ||
|
||
# - uses: actions/setup-node@v3 | ||
# with: | ||
# node-version: '16.x' | ||
# registry-url: 'https://registry.npmjs.org' | ||
|
||
# - name: Generate branch name | ||
# run: echo "BRANCH_NAME=OSBotify-bump-version-$(uuidgen)" >> $GITHUB_ENV | ||
|
||
# - name: Create branch for version-bump pull request | ||
# run: git checkout -b ${{ env.BRANCH_NAME }} | ||
|
||
# - name: Install npm packages | ||
# run: npm ci | ||
|
||
# - name: Update npm version | ||
# run: npm version patch | ||
|
||
# - name: Set new version in GitHub ENV | ||
# run: echo "NEW_VERSION=$(jq '.version' package.json)" >> $GITHUB_ENV | ||
|
||
# - name: Push branch and publish tags | ||
# run: git push --set-upstream origin ${{ env.BRANCH_NAME }} && git push --tags | ||
|
||
# - name: Create pull request | ||
# run: | | ||
# gh pr create \ | ||
# --title "Update version to ${{ env.NEW_VERSION }}" \ | ||
# --body "Update version to ${{ env.NEW_VERSION }}" | ||
# sleep 5 | ||
# env: | ||
# GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} | ||
|
||
# - name: Auto-approve pull request | ||
# run: gh pr review --approve ${{ env.BRANCH_NAME }} | ||
# env: | ||
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
# - name: Auto-merge pull request | ||
# run: gh pr merge --merge --delete-branch ${{ env.BRANCH_NAME }} | ||
# env: | ||
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
# - name: Build package | ||
# run: npm run build | ||
|
||
# - name: Publish to npm | ||
# run: npm publish | ||
# env: | ||
# NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# The GH actions don't seem to compile and verify themselves well when Prettier is applied to them | ||
.github/actions/javascript/**/index.js | ||
dist/**/*.js | ||
assets/animations | ||
android | ||
ios | ||
vendor | ||
package.json | ||
package-lock.json | ||
yarn.lock | ||
*.html | ||
*.yml | ||
*.yaml | ||
*.css | ||
*.scss | ||
*.md | ||
example/**/* | ||
.eslintrc.js | ||
react-native-live-markdown-parser.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
module.exports = { | ||
tabWidth: 4, | ||
singleQuote: true, | ||
trailingComma: 'all', | ||
bracketSpacing: false, | ||
arrowParens: 'always', | ||
printWidth: 190, | ||
singleAttributePerLine: true, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,15 @@ | ||
module.exports = { | ||
presets: ['module:metro-react-native-babel-preset'], | ||
}; | ||
module.exports = (api) => { | ||
const isWeb = api.caller((caller) => caller && caller.target === 'web'); | ||
if (isWeb) { | ||
return { | ||
// Default browser list is a reasonable preset covering a wide list of non-dead browsers | ||
// https://github.com/browserslist/browserslist#best-practices | ||
targets: 'defaults', | ||
presets: ['@babel/preset-env', '@babel/preset-react'], | ||
}; | ||
} | ||
|
||
return { | ||
presets: ['module:metro-react-native-babel-preset'], | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.