Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mention preview with invalid phone number #714

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix mention preview with invalid phone number #714

merged 2 commits into from
Jun 11, 2024

Conversation

nkdengineer
Copy link
Contributor

@nkdengineer nkdengineer commented Jun 10, 2024 •
edited
Loading

Update rawInputReplacement of userMetion rule to not display as mention for the invalid phone number in the live preview.

Fixed Issues

$ Expensify/App#41078

Tests

The auto test is updated and added.

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

@nkdengineer nkdengineer marked this pull request as ready for review June 10, 2024 03:54
@nkdengineer nkdengineer requested a review from a team as a code owner June 10, 2024 03:54
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team June 10, 2024 03:55
@nkdengineer nkdengineer mentioned this pull request Jun 10, 2024
Closed
6 tasks
@hungvu193
Copy link
Contributor

Please checkout this case

Screen.Recording.2024-06-11.at.14.14.57.mov

@nkdengineer
Copy link
Contributor Author

@hungvu193 I missed to fix rawInputReplacement in the previous Expensify-common so the latest live-markdown doesn't fix this case. That is the reason I create another PR, we need to merge this PR and bump live-markdown version one more time. And then this case will be fixed.

@hungvu193
Copy link
Contributor

@hungvu193 I missed to fix rawInputReplacement in the previous Expensify-common so the latest live-markdown doesn't fix this case. That is the reason I create another PR, we need to merge this PR and bump live-markdown version one more time. And then this case will be fixed.

I see. Can you please provide the detail of this PR in your PR's description above?

@nkdengineer
Copy link
Contributor Author

I updated.

@hungvu193
Copy link
Contributor

Thank you.
This is ready for your final review @blimpich

@cristipaval cristipaval requested review from blimpich and removed request for cristipaval June 11, 2024 10:48
@blimpich blimpich merged commit 634e3d0 into Expensify:main Jun 11, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

🚀Published to npm in v2.0.12

@nkdengineer nkdengineer mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blimpich blimpich blimpich approved these changes

@hungvu193 hungvu193 hungvu193 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkdengineer @hungvu193 @blimpich