Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow to parse link with multiline alias text when header markdown is leading- fix regression issues #605

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Do not allow to parse link with multiline alias text when header markdown is leading- fix regression issues #605

merged 1 commit into from
Nov 16, 2023

Conversation

r3770
Copy link
Contributor

@r3770 r3770 commented Nov 16, 2023

Fixed Issues

$ Expensify/App#26942
Proposal: Expensify/App#26942 (comment)

Tests

Same as QA step

Offline tests

Same as QA step

QA

  1. Go to any chat
  2. In composer, send message as following
    # [google1
    google2
    google3](https://www.google.com)
  1. Verify that the first line ([google1) is parsed as header, and https://www.google.com will be parsed as autolink.

Screenshots/Videos

Web

image

Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@r3770 r3770 requested a review from a team as a code owner November 16, 2023 00:47
@melvin-bot melvin-bot bot requested review from hayata-suenaga and removed request for a team November 16, 2023 00:47
@r3770
Copy link
Contributor Author

r3770 commented Nov 16, 2023

@cead22
I've fixed regression issues which is that autolink & autoemail with h1 tag is not allowed to parse

@r3770 r3770 mentioned this pull request Nov 16, 2023
Closed
6 tasks
@cead22
Copy link
Contributor

cead22 commented Nov 16, 2023

@robertKozik can you comment here so I can assign you? Although if this change looks good to you @hayata-suenaga feel free to approve and merge

hayata-suenaga
hayata-suenaga approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@hayata-suenaga hayata-suenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me from my perspective, but I'll wait for Robert's review

@robertKozik
Copy link
Contributor

On it 👀

@robertKozik
Copy link
Contributor

For me it looks good as well

Screen.Recording.2023-11-16.at.20.13.27.mov

@cead22 cead22 merged commit 7c72af4 into Expensify:main Nov 16, 2023
5 checks passed
@tienifr tienifr mentioned this pull request Nov 24, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayata-suenaga hayata-suenaga hayata-suenaga approved these changes

@robertKozik robertKozik robertKozik approved these changes

@cead22 cead22 cead22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r3770 @cead22 @robertKozik @hayata-suenaga