Fix problem with parsing links containing mailto: prefix followed by an email #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Nov 16, 2023
lib/ExpensiMark.js
Outdated
Comment on lines
71
to
76
| let label = g1.trim(); | ||
| const href = `mailto:${g2}`; | ||
| if (label === href) { | ||
| label = g2; | ||
| } | ||
| return `<a href="${href}">${label}</a>`; |
There was a problem hiding this comment.
I don't like the fact that we mutate label here but honestly I cannot think of anything better that wouldn't require duplicating <a href="..."> string.
melvin-bot
bot
requested review from
jasperhuangg
and removed request for
a team
|
@jasperhuangg bump |
20 tasks
jasperhuangg
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes potential problems with parsing links containing mailto: prefix followed by an email. The changes were added to enhance parsing inside Live Markdown Preview.
The problem was mainly with parsing
[mailto:[email protected]](mailto:[email protected]). ExpensiMark instead of one link returns two separate tags inside brackets:To fix the problem we decided to collapse such links, similarly like it is done after writing
[[email protected]]([email protected]).So now following strings:
[[email protected]](mailto:[email protected])[mailto:[email protected]]([email protected])[mailto:[email protected]](mailto:[email protected])will be collapsed into:
<a href=\"mailto:[email protected]\">[email protected]</a>mailto.parsing.mov
Fixed Issues
$ Expensify/App#31181
Tests
To test these changes I've added proper tests connected to all needed behaviors for Live Markdown Preview. To test it by yourself you should:
QA
Same as tests