Merge pull request #1786 from Expensify/cole_srandom

Make SRandom::randStr() not require a reference
Expensify · Jun 25, 2024 · f636d81 · f636d81
2 parents 4ce6f15 + 9ee40c7
commit f636d81
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/libstuff/SRandom.cpp b/libstuff/SRandom.cpp
@@ -18,13 +18,13 @@ uint64_t SRandom::rand64() {
     return _distribution64(_generator);
 }
 
-string SRandom::randStr(uint& length) {
+string SRandom::randStr(uint length) {
     string str = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
     string newstr;
     int pos;
-    while(newstr.size() != length) {
+    while (newstr.size() != length) {
         pos = (rand64() % (str.size() - 1));
-        newstr += str.substr(pos,1);
+        newstr += str.substr(pos, 1);
     }
     return newstr;
 }
diff --git a/libstuff/SRandom.h b/libstuff/SRandom.h
@@ -10,7 +10,7 @@ class SRandom {
   public:
     static uint64_t rand64();
     static uint64_t limitedRand64(uint64_t min, uint64_t max);
-    static string randStr(uint& length);
+    static string randStr(uint length);
 
   private:
     static mt19937_64 _generator;