fix: 10731 Focus composer without showing keyboard when users go to chats #32711

christianwen · 2023-12-08T10:18:29Z

Details

Fixed Issues

$ #10731
PROPOSAL: #10731 (comment)

Tests

Go to any chats
Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go to any chats
Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

e-android.native.mov

Android: mWeb Chrome

e-android.mweb.mov

iOS: Native

e-ios.mov

iOS: mWeb Safari

e-safari.mov

MacOS: Chrome / Safari

e-web.mov

MacOS: Desktop

e-desktop.mov

melvin-bot · 2023-12-11T08:45:46Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiros · 2023-12-11T11:55:17Z

Go to any chats

Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown

I am not sure if this is the expected behavior. @ntdiary can you confirm this doesn't conflict with your refactor?

Santhosh-Sellavel · 2023-12-11T18:25:52Z

I am not sure if this is the expected behavior.
@0xmiroslav Can you add more context for this why you think this way?

ntdiary · 2023-12-12T08:40:13Z

Go to any chats

Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown

I am not sure if this is the expected behavior. @ntdiary can you confirm this doesn't conflict with your refactor?

I need some time to understand this issue first. :)

Santhosh-Sellavel · 2023-12-14T18:37:12Z

@ntdiary @0xmiroslav bump

I am not sure if this is the expected behavior.

@0xmiroslav Can you add more context for this why you think this way?

ntdiary · 2023-12-15T04:10:43Z

@ntdiary @0xmiroslav bump

I am not sure if this is the expected behavior.

@0xmiroslav Can you add more context for this why you think this way?

@Santhosh-Sellavel, we have a PR #29199 that aims to standardize the behavior of refocusing when a modal is closed (including BaseModal, PopoverWithoutOverlay, and RHP), which will address many refocusing issues. The basic principle is that if there is a focused input box before opening the modal, then the focus will be restored after closing the modal. If there is no focus before opening, then it will not be restored.

So, after it is merged, the main input box will no longer gain focus if we complete the money request from the green plus button, which means that the keyboard will no longer be pulled up (for all mobile native/mWeb platforms).

As for whether the main composer should be focused when we open a chat from LHN, it is beyond the scope of that PR.

demo.mp4

Santhosh-Sellavel · 2023-12-25T19:17:38Z

@christianwen can you resolve conflicts, please?

christianwen · 2024-01-02T08:59:19Z

merged main

Santhosh-Sellavel · 2024-01-24T20:12:16Z

@christianwen Sorry for the delay, can resolve conflicts please?

christianwen · 2024-01-25T10:08:28Z

@Santhosh-Sellavel I fixed the conflicts, can you help process review this PR to avoid the conflicts? Thanks

Santhosh-Sellavel · 2024-01-25T19:35:31Z

@christianwen
Bug: On tapping composer to bring Keyboard, Keyboard gets dismissed automatically on mWeb iOS

Screen.Recording.2024-01-26.at.1.04.52.AM.mov

christianwen · 2024-01-29T10:02:45Z

Checking...

Santhosh-Sellavel · 2024-02-01T12:14:45Z

Any update?

Santhosh-Sellavel · 2024-02-02T17:15:36Z

Bump @christianwen

christianwen · 2024-02-04T15:22:12Z

I faced with some errors when building iOS.Pls give me a day to fix it

Santhosh-Sellavel · 2024-02-04T17:43:27Z

@christianwen
Bug: On tapping composer to bring Keyboard, Keyboard gets dismissed automatically on mWeb iOS

Screen.Recording.2024-01-26.at.1.04.52.AM.mov

@christianwen this happens on mWeb iOS

Santhosh-Sellavel · 2024-02-07T17:28:07Z

Any update @christianwen

DylanDylann · 2024-09-25T10:44:34Z

BUG: The keyboard doesn't show on Android (only show if clicking two times)

Screen.Recording.2024-09-25.at.17.44.01.mov

DylanDylann · 2024-09-25T16:08:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-25.at.23.11.55.mov

Android: mWeb Chrome

Screen.Recording.2024-09-25.at.23.10.40.mov

iOS: Native

Screen.Recording.2024-09-25.at.23.12.23.mov

iOS: mWeb Safari

Screen.Recording.2024-09-25.at.23.10.15.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-25.at.23.09.27.mov

MacOS: Desktop

Screen.Recording.2024-09-25.at.23.12.43.mov

DylanDylann · 2024-09-25T16:18:52Z

Just a note:

Changed files ESLint check
This action failed because of https://expensify.slack.com/archives/C01GTK53T8Q/p1726169039084589. This PR is complicated, so I think we should migrate withOnyx to useOnyx in another PR
Reassure Performance Tests
As mentioned above

Updated! For the perf issue, we shouldn't mind about it since this test is to compare the number of re-render when users interact with input in baseline (from main) with the current behavior (this PR). In this PR we try to open the keyboard when they focus on the composer -> it takes 2 times to re-render

This PR will change the current behavior on purpose

DylanDylann · 2024-09-25T16:19:12Z

@iwiznia All yours

christianwen · 2024-09-30T03:47:06Z

@iwiznia Can you take a look at this PR? Thanks

iwiznia · 2024-09-30T13:41:17Z

Checks failed

DylanDylann · 2024-09-30T14:56:35Z

@iwiznia Please check this comment: #32711 (comment)

melvin-bot · 2024-09-30T15:58:52Z

@iwiznia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

iwiznia · 2024-09-30T15:59:03Z

See #32711 (comment)

OSBotify · 2024-09-30T16:10:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-09-30T22:56:59Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.0.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

iwiznia · 2024-10-01T15:31:47Z

Going to revert the PR since it caused #49977

DylanDylann · 2024-10-01T15:33:06Z

@christianwen Could you create a quick PR to address this bug?

github-actions · 2024-10-02T00:19:50Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.42-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rojiphil · 2024-11-11T13:59:16Z

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

-        !modal?.isVisible &&
-        Modal.areAllModalsHidden() &&
-        isFocused &&
-        (shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction))) &&


~~Probably a design issue as we did not notice that the keyboard display on mobile platforms would cover the task description and cause UX issue #50346~~
Sorry. Wrong place to comment this

@rojiphil This PR was reverted

Oh! Thanks for pointing this out. Didn't notice this. Let me dig a little deeper.

christianwen added 3 commits December 8, 2023 17:13

fix: 10731

d8eb426

Merge branch 'main' into fix/10731-chat-composer-behavior

07fdad0

lint fix

a5f99b7

christianwen marked this pull request as ready for review December 11, 2023 08:45

christianwen requested a review from a team as a code owner December 11, 2023 08:45

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team December 11, 2023 08:45

christianwen changed the title ~~fix: 10731~~ fix: 10731 Focus composer without showing keyboard when users go to chats Dec 11, 2023

christianwen mentioned this pull request Dec 11, 2023

[HOLD for payment 2024-10-22] [$2000] Android/IOS - Split/request money - Chat composer is focused after IOU request from green plus button #10731

Open

resolve conflict

f764d66

lint fix

f6e2e28

fix confict

4b19bdf

lint fix

7e930b8

christianwen added 2 commits September 25, 2024 17:09

safari keyboard show

381fdff

lint fix

e08d442

christianwen added 2 commits September 25, 2024 18:07

remove redundant fix

2282bf6

lint fix

1245315

DylanDylann approved these changes Sep 25, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia September 25, 2024 16:14

resolve conflicts

33e093e

iwiznia approved these changes Sep 30, 2024

View reviewed changes

iwiznia merged commit a9224f3 into Expensify:main Sep 30, 2024
14 of 16 checks passed

melvin-bot bot added the Emergency label Sep 30, 2024

iwiznia removed the Emergency label Sep 30, 2024

github-actions bot mentioned this pull request Sep 30, 2024

Deploy Checklist: New Expensify 2024-09-30 #49960

Closed

49 tasks

hungvu193 mentioned this pull request Oct 1, 2024

iOS - Composer - No copy paste option in edit mode #49977

Closed

6 tasks

iwiznia mentioned this pull request Oct 1, 2024

[CP] Revert "fix: 10731 Focus composer without showing keyboard when users go to chats" #50003

Merged

DylanDylann mentioned this pull request Oct 7, 2024

fix: 10731 #50279

Merged

50 tasks

rojiphil reviewed Nov 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 10731 Focus composer without showing keyboard when users go to chats #32711

fix: 10731 Focus composer without showing keyboard when users go to chats #32711

christianwen commented Dec 8, 2023 •

edited

Loading

melvin-bot bot commented Dec 11, 2023

0xmiros commented Dec 11, 2023

Santhosh-Sellavel commented Dec 11, 2023

ntdiary commented Dec 12, 2023

Santhosh-Sellavel commented Dec 14, 2023 •

edited

Loading

ntdiary commented Dec 15, 2023

Santhosh-Sellavel commented Dec 25, 2023

christianwen commented Jan 2, 2024

Santhosh-Sellavel commented Jan 24, 2024

christianwen commented Jan 25, 2024

Santhosh-Sellavel commented Jan 25, 2024 •

edited

Loading

christianwen commented Jan 29, 2024

Santhosh-Sellavel commented Feb 1, 2024

Santhosh-Sellavel commented Feb 2, 2024

christianwen commented Feb 4, 2024

Santhosh-Sellavel commented Feb 4, 2024

Santhosh-Sellavel commented Feb 7, 2024

DylanDylann commented Sep 25, 2024

DylanDylann commented Sep 25, 2024 •

edited

Loading

DylanDylann commented Sep 25, 2024

DylanDylann commented Sep 25, 2024

christianwen commented Sep 30, 2024

iwiznia commented Sep 30, 2024

DylanDylann commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

iwiznia commented Sep 30, 2024

OSBotify commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

iwiznia commented Oct 1, 2024

DylanDylann commented Oct 1, 2024

github-actions bot commented Oct 2, 2024

rojiphil Nov 11, 2024 •

edited

Loading

DylanDylann Nov 11, 2024 •

edited

Loading

rojiphil Nov 11, 2024

fix: 10731 Focus composer without showing keyboard when users go to chats #32711

fix: 10731 Focus composer without showing keyboard when users go to chats #32711

Conversation

christianwen commented Dec 8, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 11, 2023

0xmiros commented Dec 11, 2023

Santhosh-Sellavel commented Dec 11, 2023

ntdiary commented Dec 12, 2023

Santhosh-Sellavel commented Dec 14, 2023 • edited Loading

ntdiary commented Dec 15, 2023

Santhosh-Sellavel commented Dec 25, 2023

christianwen commented Jan 2, 2024

Santhosh-Sellavel commented Jan 24, 2024

christianwen commented Jan 25, 2024

Santhosh-Sellavel commented Jan 25, 2024 • edited Loading

christianwen commented Jan 29, 2024

Santhosh-Sellavel commented Feb 1, 2024

Santhosh-Sellavel commented Feb 2, 2024

christianwen commented Feb 4, 2024

Santhosh-Sellavel commented Feb 4, 2024

Santhosh-Sellavel commented Feb 7, 2024

DylanDylann commented Sep 25, 2024

DylanDylann commented Sep 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Sep 25, 2024

DylanDylann commented Sep 25, 2024

christianwen commented Sep 30, 2024

iwiznia commented Sep 30, 2024

DylanDylann commented Sep 30, 2024

melvin-bot bot commented Sep 30, 2024

iwiznia commented Sep 30, 2024

OSBotify commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

iwiznia commented Oct 1, 2024

DylanDylann commented Oct 1, 2024

github-actions bot commented Oct 2, 2024

rojiphil Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

DylanDylann Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

rojiphil Nov 11, 2024

Choose a reason for hiding this comment

christianwen commented Dec 8, 2023 •

edited

Loading

Santhosh-Sellavel commented Dec 14, 2023 •

edited

Loading

Santhosh-Sellavel commented Jan 25, 2024 •

edited

Loading

DylanDylann commented Sep 25, 2024 •

edited

Loading

rojiphil Nov 11, 2024 •

edited

Loading

DylanDylann Nov 11, 2024 •

edited

Loading