Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation - Weird goBack behaviour #47534

Open
6 tasks done
shubham1206agra opened this issue Aug 16, 2024 · 16 comments
Open
6 tasks done

Navigation - Weird goBack behaviour #47534

shubham1206agra opened this issue Aug 16, 2024 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2

Comments

@shubham1206agra
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue reported by: @shubham1206agra
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1719319215720149

If we perform goBack with a fallback route to a FullScreen Navigator from RHP, it will create another Full Screen Navigator on top of the original Full Screen Navigator instead of just popping the RHP screen.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Use goBack without a fallback route.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-06-25.at.5.55.17.PM.mov

cc @adamgrzybowski @mountiny

View all open jobs on GitHub

@shubham1206agra shubham1206agra added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Aug 16, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jliexpensify
Copy link
Contributor

I'll just wait for @adamgrzybowski to comment so I can assign him

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

@jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@jliexpensify
Copy link
Contributor

Not overdue, looking to assign @adamgrzybowski once he comments

@melvin-bot melvin-bot bot removed the Overdue label Aug 20, 2024
@adamgrzybowski
Copy link
Contributor

Hey @jliexpensify @shubham1206agra, I can't open the Slack thread. Could you please remind me why we can't just use goBack without the fallback route?

@jliexpensify
Copy link
Contributor

Sure, this is (I think) what is relevant to your question?

image

But @shubham1206agra can weigh in and summarise.

@adamgrzybowski
Copy link
Contributor

Great thanks! You can assign me but could we please set like to the lowest priority possible? I am currently working on POC with some changes in navigation and these changes may help with this issue. I will have this issue in mind and test it after finishing implementing navigation changes.

@jliexpensify
Copy link
Contributor

Sure, assigned - I'm not sure which project this falls into though?

@jliexpensify jliexpensify added Weekly KSv2 and removed Daily KSv2 labels Aug 20, 2024
@adamgrzybowski
Copy link
Contributor

There is an issue that started my work on POC. Not sure if it falls into any project but the closest would be the ideal-nav. I think we finished it some time ago though.

@jliexpensify
Copy link
Contributor

Hmm ok, in that case - it's probably going to be project-less? @adamgrzybowski I have set this to Weekly but let me know if you'd like it Monthly instead.

@adamgrzybowski
Copy link
Contributor

Maybe monthly? I am going to be OOO soon for two weeks 😄 We don't want to upset Melvin

@jliexpensify jliexpensify added Monthly KSv2 and removed Weekly KSv2 labels Aug 21, 2024
@jliexpensify
Copy link
Contributor

Easy, done! I assume you'll be working on this solo - i.e. no need for payments to anyone, except maybe a C+ who might review a PR?

@adamgrzybowski
Copy link
Contributor

Correct!

Copy link

melvin-bot bot commented Aug 30, 2024

@jliexpensify @adamgrzybowski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@jliexpensify
Copy link
Contributor

@shubham1206agra this is still happening, correct? Could you please list out the flow/reproduction steps so we can better understand the actual issue and how we can prioritise it (especially since another issue has been now linked)? Thank you!

@jliexpensify
Copy link
Contributor

Bump @shubham1206agra on my comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants