[HOLD][$250] Xero - Strange animation after dismissing 2FA setup RHP and not here page on LHN

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.8-1
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #44059
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User has a workspace.
• The workspace is connected to Xero.
• User has not set up 2FA.

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Log in to the account from precondition.
4. Click Enable two-factor authentication.
5. Click the back button on 2FA set up RHP.
6. Navigate between Account settings, Search and Inbox.

Expected Result:

App should throw 2FA set up modal again if user exits 2FA set up flow.

Actual Result:

In Step 5, when clicking on back button on 2FA setup RHP, the RHP dismissal has a weird animation.
In Step 6, after switching between sections, not here page shows up on the left hand panel.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6544785_1721201414390.20240717_152508.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2d69ad81006978f
• Upwork Job ID: 1813578824903964216
• Last Price Increase: 2024-09-04

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[MonilBhavsar]

Commented on the offending PR #44059

[rushatgabhane]

The issue is present after reverting this PR too. its unrelated to the PR and related to navigation

[MonilBhavsar]

Ok thanks for checking!

[MonilBhavsar]

The issue is present after reverting this PR too.

@rushatgabhane if we revert this PR, then the 2FA modal doesn't show up and looks like issue is not reproducible?

[rushatgabhane]

@MonilBhavsar let me rephrase what i mean - this same issue is present on production also. The PR above did not make any changes to how back navigation was handled

1. Go to production - https://new.expensify.com/settings/security/two-factor-auth?backTo=home
2. Click back

Screen.Recording.2024-07-17.at.17.12.45.mov

[MonilBhavsar]

Ok thanks for clarifying. Makes sense

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2d69ad81006978f

[ahmedGaber93]

Waiting on proposals.

[ahmedGaber93]

@VictoriaExpensify @MonilBhavsar we don't have accepted proposals yet, I think we can share this issue with SWM instead of waiting for new proposals, They always handle the navigation issues.

CC @adamgrzybowski

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MonilBhavsar]

what do you think of asking SWM to handle this?

Let's get some thoughts 👍 I see you have tagged Adam Grzybowski

[adamgrzybowski]

Hey guys, we are currently working on some changes to the navigation that will influence how the goBack works. My question is how urgent is this fix? We can work on some solution, but it will probably be discarded after these changes.

BTW Maybe as a simple fix, we can just not use the HOME as a param for the goBack function? We could use a combination of dismissModal and navigate to HOME?

[ahmedGaber93]

Not overdue, we are still discussing the solution

[ahmedGaber93]

@MonilBhavsar What do you think #45572 (comment)?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@MonilBhavsar, @ahmedGaber93, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[VictoriaExpensify]

Yeah I don't think this is urgent @adamgrzybowski . I think it makes sense to put this on the back-burner and revisit it once the other navigation changes are in place. Do you have a GH for those changes that we ca reference here?

[VictoriaExpensify]

Not overdue

[VictoriaExpensify]

bump @adamgrzybowski :

Yeah I don't think this is urgent @adamgrzybowski . I think it makes sense to put this on the back-burner and revisit it once the other navigation changes are in place. Do you have a GH for those changes that we can reference here?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[trjExpensify]

we are currently working on some changes to the navigation that will influence how the goBack works. My question is how urgent is this fix? We can work on some solution, but it will probably be discarded after these changes.

What changes are these, and can you link an issue? I don't think this is super pressing, but If we're putting it on hold, let's make sure that's reflected in the issue title.

[VictoriaExpensify]

Ok I think this is the issue @adamgrzybowski was referencing - #47534

He's gone ooo and that issue has been changed to monthly, so I think we're safe to put this on hold for now

[VictoriaExpensify]

Not OD, this is on hold