refactor code

Expensify · Oct 16, 2024 · ae08042 · ae08042
1 parent 210fa09
commit ae08042
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/pages/workspace/accounting/AccountingContext.tsx b/src/pages/workspace/accounting/AccountingContext.tsx
@@ -74,7 +74,7 @@ function AccountingContextProvider({children, policy}: AccountingContextProvider
             );
             const workspaceUpgradeNavigationDetails = accountingIntegrationData?.workspaceUpgradeNavigationDetails;
             if (workspaceUpgradeNavigationDetails && !isControlPolicy(policy)) {
-                workspaceUpgradeNavigationDetails.sideEffect?.();
+                workspaceUpgradeNavigationDetails.eventBeforeNavigation?.();
 
                 Navigation.navigate(
                     ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, workspaceUpgradeNavigationDetails.integrationAlias, workspaceUpgradeNavigationDetails.backToAfterWorkspaceUpgradeRoute),

diff --git a/src/pages/workspace/accounting/types.ts b/src/pages/workspace/accounting/types.ts
@@ -23,7 +23,7 @@ type WorkspaceUpgradeNavigationDetails = {
     /** Route to redirect to after upgrading the workspace */
     backToAfterWorkspaceUpgradeRoute: string;
     /** Function to call after upgrading the workspace */
-    sideEffect?: () => void;
+    eventBeforeNavigation?: () => void;
 };
 
 type AccountingIntegration = {

diff --git a/src/pages/workspace/accounting/utils.tsx b/src/pages/workspace/accounting/utils.tsx
@@ -284,7 +284,7 @@ function getAccountingIntegrationData(
                 subscribedAdvancedSettings: [CONST.QUICKBOOKS_DESKTOP_CONFIG.SHOULD_AUTO_CREATE_VENDOR, CONST.QUICKBOOKS_DESKTOP_CONFIG.AUTO_SYNC],
                 workspaceUpgradeNavigationDetails: {
                     integrationAlias: CONST.UPGRADE_FEATURE_INTRO_MAPPING.quickbooksDesktop.alias,
-                    sideEffect: () => {
+                    eventBeforeNavigation: () => {
                         // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
                         if (isSmallScreenWidth || integrationToDisconnect) {
                             return;