-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Xmp toolkit v2023-12 submodule #3014
base: main
Are you sure you want to change the base?
Conversation
9027573
to
2b479ec
Compare
There are some changes in behavior of One major change I encountered is setting of aliased properties. Previously as far as I understand sdk did not care about aliasing whatsoever, the newer version do and attempt to handle them according to specifications.
XMPSpecificationPart2.pdf page 8 I found this comment in sources
Handling aliases in So with this patch And because
XmpSpecificationPart1 page 30 |
6532cd6
to
709ba45
Compare
…sdk does not like it anymore
709ba45
to
a3284aa
Compare
This merge request attempts to pull
XMP-Toolkit-SDK
as a submodule. Due to the complicated and messy build system inXMP-Toolkit-SDK
, I avoid using it and instead use the existing in-tree build system with some modifications.I have made several hacky workarounds:
/third-party/expat/lib/expat.h
inXMP-Toolkit-SDK
. Since we pullexpat
as an external dependency, I had to copyexpat.h
to a fakethird-party/expat/lib/
directory in the build folder at generation time. I am not quite sure if the same will be possible withmeson
.MD5Update
has a slightly different signature, so I used aconst_cast
. I expect to get rid of this when I do a refactoring.SXMPMeta::DeleteNamespace
seems to be deprecated in this version, which needs further investigation.To-do:
XMP-Toolkit-SDK
requires, e.g.,WIN_ENV
,WIN_UNIVERSAL_ENV
, etc.meson
.xmp.cpp
and all associated files.