coverity fixes #2673
Merged
coverity fixes #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
- Coverage 63.92% 63.89% -0.03%
==========================================
Files 103 103
Lines 22305 22313 +8
Branches 10795 10799 +4
==========================================
Hits 14258 14258
- Misses 5826 5830 +4
- Partials 2221 2225 +4
|
| if (currentStream_ == Video) | ||
| if (currentStream_ == Video) { | ||
| if (timeOfFrames == 0) | ||
| timeOfFrames = 1; |
There was a problem hiding this comment.
@neheb: Did coverity complain about a possible divide-by-zero? I'm not convinced it's a bug. We're using floating point arithmetic here, so it wouldn't cause a crash - it would just compute Inf or NaN.
There was a problem hiding this comment.
Yeah that's it. I'm not convinced it can be 0 based on the above code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.