unitTests: fix sign comparison warnings

Signed-off-by: Rosen Penev <[email protected]>
Exiv2 · Feb 16, 2024 · 149fe1e · 149fe1e
1 parent 84ce408
commit 149fe1e
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 11 deletions.
diff --git a/unitTests/test_DateValue.cpp b/unitTests/test_DateValue.cpp
@@ -151,7 +151,7 @@ TEST(ADateValue, copiesToByteBufferWithBasicFormat) {
   std::array<byte, 8> buf = {};
 
   const byte expectedDate[10] = {'2', '0', '2', '1', '1', '2', '0', '1'};
-  ASSERT_EQ(8, dateValue.copy(buf.data()));
+  ASSERT_EQ(8u, dateValue.copy(buf.data()));
   ASSERT_TRUE(std::equal(buf.begin(), buf.end(), expectedDate));
 }
 

diff --git a/unitTests/test_FileIo.cpp b/unitTests/test_FileIo.cpp
@@ -53,7 +53,7 @@ TEST(AFileIO, returnsFileSizeEvenWhenFileItIsNotOpened) {
 TEST(AFileIO, isOpenedAtPosition0) {
   FileIo file(imagePath);
   file.open();
-  ASSERT_EQ(0, file.tell());
+  ASSERT_EQ(0u, file.tell());
 }
 
 TEST(AFileIO, canSeekToExistingPositions) {

diff --git a/unitTests/test_Photoshop.cpp b/unitTests/test_Photoshop.cpp
@@ -76,8 +76,8 @@ TEST(PhotoshopLocateIrb, returns0withGoodIptcIrb) {
   uint32_t sizeData = 0;
 
   ASSERT_EQ(0, Photoshop::locateIrb(data.data(), data.size(), Photoshop::iptc_, &record, sizeHdr, sizeData));
-  ASSERT_EQ(12, sizeHdr);
-  ASSERT_EQ(27, sizeData);
+  ASSERT_EQ(12u, sizeHdr);
+  ASSERT_EQ(27u, sizeData);
 }
 
 TEST(PhotoshopLocateIptcIrb, returns0withGoodIptcIrb) {

diff --git a/unitTests/test_TimeValue.cpp b/unitTests/test_TimeValue.cpp
@@ -151,7 +151,7 @@ TEST(ATimeValue, cannotReadFromStringWithBadFormat) {
 TEST(ATimeValue, isCopiedToBuffer) {
   const TimeValue value(23, 55, 2);
   byte buffer[11];
-  ASSERT_EQ(11, value.copy(buffer));
+  ASSERT_EQ(11u, value.copy(buffer));
 
   const byte expectedDate[11] = {'2', '3', '5', '5', '0', '2', '+', '0', '0', '0', '0'};
   for (int i = 0; i < 11; ++i) {

diff --git a/unitTests/test_basicio.cpp b/unitTests/test_basicio.cpp
@@ -10,7 +10,7 @@ using namespace Exiv2;
 TEST(MemIoDefault, readEReturns0) {
   std::array<byte, 10> buf;
   MemIo io;
-  ASSERT_EQ(0, io.read(buf.data(), buf.size()));
+  ASSERT_EQ(0u, io.read(buf.data(), buf.size()));
 }
 
 TEST(MemIoDefault, isNotAtEof) {
@@ -44,7 +44,7 @@ TEST(MemIoDefault, seekToEndPositionAndReadTriggersEof) {
   ASSERT_EQ(0, io.tell());
 
   std::array<byte, 64> buf2 = {};
-  ASSERT_EQ(0, io.read(buf2.data(), 1));  // Note that we cannot even read 1 byte being at the end
+  ASSERT_EQ(0u, io.read(buf2.data(), 1));  // Note that we cannot even read 1 byte being at the end
   ASSERT_TRUE(io.eof());
 }
 

diff --git a/unitTests/test_bmpimage.cpp b/unitTests/test_bmpimage.cpp
@@ -88,8 +88,8 @@ TEST(BmpImage, readMetadataReadsImageDimensionsWhenDataIsAvailable) {
   auto memIo = std::make_unique<MemIo>(header.data(), header.size());
   BmpImage bmp(std::move(memIo));
   ASSERT_NO_THROW(bmp.readMetadata());
-  ASSERT_EQ(1280, bmp.pixelWidth());
-  ASSERT_EQ(800, bmp.pixelHeight());
+  ASSERT_EQ(1280u, bmp.pixelWidth());
+  ASSERT_EQ(800u, bmp.pixelHeight());
 }
 
 TEST(BmpImage, readMetadataThrowsWhenImageIsNotBMP) {

diff --git a/unitTests/test_matroskavideo.cpp b/unitTests/test_matroskavideo.cpp
@@ -51,5 +51,5 @@ TEST(MatroskaVideo, readMetadata) {
   ASSERT_NO_THROW(mkv.setXmpData(xmpData));
   auto data = mkv.xmpData();
   ASSERT_FALSE(data.empty());
-  ASSERT_EQ(xmpData["Xmp.video.TotalStream"].count(), 4);
+  ASSERT_EQ(xmpData["Xmp.video.TotalStream"].count(), 4u);
 }
diff --git a/unitTests/test_pngimage.cpp b/unitTests/test_pngimage.cpp
@@ -20,7 +20,7 @@ TEST(PngChunk, keyTxtChunkExtractsKeywordCorrectlyInPresenceOfNullChar) {
 
   DataBuf chunkBuf(data.data(), data.size());
   DataBuf key = Internal::PngChunk::keyTXTChunk(chunkBuf, true);
-  ASSERT_EQ(21, key.size());
+  ASSERT_EQ(21u, key.size());
 
   ASSERT_TRUE(std::equal(key.data(), key.data() + key.size(), data.data() + 8));
 }