Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix typo in limit example #3303

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[DOCS] Fix typo in limit example #3303

merged 1 commit into from
Nov 15, 2024

Conversation

colin-ho
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 15, 2024
@colin-ho colin-ho enabled auto-merge (squash) November 15, 2024 16:51
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #3303 will degrade performances by 40.18%

Comparing colin/fix-limit-example (a37126f) with main (ca8f25d)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main colin/fix-limit-example Change
test_iter_rows_first_row[100 Small Files] 369.1 ms 279.3 ms +32.12%
test_show[100 Small Files] 15 ms 25 ms -40.18%

@colin-ho colin-ho merged commit a271c78 into main Nov 15, 2024
41 of 42 checks passed
@colin-ho colin-ho deleted the colin/fix-limit-example branch November 15, 2024 17:11
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (ca8f25d) to head (a37126f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3303      +/-   ##
==========================================
+ Coverage   75.90%   77.66%   +1.75%     
==========================================
  Files         667      668       +1     
  Lines       83922    82100    -1822     
==========================================
+ Hits        63699    63761      +62     
+ Misses      20223    18339    -1884     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 86.65% <ø> (ø)

... and 20 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant