Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sammy/factor out io libs #3266

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Sammy/factor out io libs #3266

wants to merge 6 commits into from

Conversation

samster25
Copy link
Member

No description provided.

Copy link

This PR is being prevented from merging because you need at least one of the required labels:

enhancement | performance | bug | chore | documentation | dependencies

The canonical and easiest way of adding them is to add the following prefixes to your PR title:

  • [FEAT]: adds the enhancement label
  • [PERF]: adds the performance label
  • [BUG]: adds the bug label
  • [CHORE]: adds the chore label
  • [DOCS]: adds the documentation label

Thanks for helping us categorize and manage our PRs!

Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #3266 will degrade performances by 29.69%

Comparing sammy/factor-out-io-libs (c0b2626) with main (05048d9)

Summary

❌ 2 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main sammy/factor-out-io-libs Change
test_iter_rows_first_row[100 Small Files] 331.6 ms 368.7 ms -10.05%
test_show[100 Small Files] 32.2 ms 45.8 ms -29.69%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant