Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Monotonically Increasing Id for Swordfish #3180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into colin/swordfish-mono-id

509e645
Select commit
Loading
Failed to load commit list.
Open

[FEAT] Monotonically Increasing Id for Swordfish #3180

Merge branch 'main' into colin/swordfish-mono-id
509e645
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 15, 2024 in 0s

74.96% (-2.60%) compared to 84db665

View this Pull Request on Codecov

74.96% (-2.60%) compared to 84db665

Details

Codecov Report

Attention: Patch coverage is 84.84848% with 20 lines in your changes missing coverage. Please review.

Project coverage is 74.96%. Comparing base (84db665) to head (509e645).

Files with missing lines Patch % Lines
...execution/src/sinks/monotonically_increasing_id.rs 77.01% 20 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3180      +/-   ##
==========================================
- Coverage   77.55%   74.96%   -2.60%     
==========================================
  Files         668      669       +1     
  Lines       82268    86911    +4643     
==========================================
+ Hits        63807    65151    +1344     
- Misses      18461    21760    +3299     
Files with missing lines Coverage Δ
src/daft-local-execution/src/pipeline.rs 95.51% <100.00%> (+0.09%) ⬆️
src/daft-local-plan/src/plan.rs 96.72% <100.00%> (+0.14%) ⬆️
src/daft-local-plan/src/translate.rs 94.15% <100.00%> (+0.24%) ⬆️
src/daft-micropartition/src/python.rs 78.32% <100.00%> (+0.04%) ⬆️
...execution/src/sinks/monotonically_increasing_id.rs 41.10% <77.01%> (ø)

... and 39 files with indirect coverage changes