[FEAT] base64_encode and base64_decode operations #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
CodSpeed Performance ReportMerging #3048 will not alter performanceComparing Summary
|
|
|
||
| pub(super) struct Base64DecodeEvaluate {} | ||
|
|
||
| impl FunctionEvaluator for Base64DecodeEvaluate { |
There was a problem hiding this comment.
we've been moving away from FunctionEvaluator and instead implementing new functions using the daft-functions crate. Here's a merged PR of migrating from the old to the new.
There was a problem hiding this comment.
Thanks for the review, let me check it.
There was a problem hiding this comment.
@universalmind303 I have submit #3101 to move utf8 from daft-dsl to dsl-functions. Then I will add those two expressions to dsl-functions. Hopefully, you have time to review it.
|
We should also support encoding binary arrays -> utf8 as base64 and also decode utf8 -> binary since that is the most common use I see for base64! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add standard base64 encode/decode supports.