Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Daft Catalog API #3036

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Remove need of using catalog_name as input arg

cc29cad
Select commit
Loading
Failed to load commit list.
Open

[FEAT] Daft Catalog API #3036

Remove need of using catalog_name as input arg
cc29cad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 15, 2024 in 0s

75.89% (-1.61%) compared to c4e1ab2

View this Pull Request on Codecov

75.89% (-1.61%) compared to c4e1ab2

Details

Codecov Report

Attention: Patch coverage is 31.73653% with 228 lines in your changes missing coverage. Please review.

Project coverage is 75.89%. Comparing base (c4e1ab2) to head (cc29cad).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-catalog/python-catalog/src/python.rs 4.44% 86 Missing ⚠️
src/daft-catalog/src/lib.rs 70.29% 30 Missing ⚠️
daft/catalog/unity.py 0.00% 28 Missing ⚠️
src/daft-catalog/src/python.rs 25.80% 23 Missing ⚠️
daft/catalog/pyiceberg.py 0.00% 20 Missing ⚠️
daft/catalog/__init__.py 56.25% 14 Missing ⚠️
daft/catalog/python_catalog.py 0.00% 13 Missing ⚠️
src/daft-catalog/src/errors.rs 0.00% 13 Missing ⚠️
daft/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3036      +/-   ##
==========================================
- Coverage   77.50%   75.89%   -1.61%     
==========================================
  Files         666      675       +9     
  Lines       81333    83898    +2565     
==========================================
+ Hits        63036    63677     +641     
- Misses      18297    20221    +1924     
Files with missing lines Coverage Δ
daft/io/catalog.py 86.95% <100.00%> (+0.91%) ⬆️
src/common/error/src/error.rs 84.84% <ø> (ø)
src/lib.rs 95.94% <100.00%> (+0.11%) ⬆️
daft/__init__.py 23.68% <0.00%> (-0.65%) ⬇️
daft/catalog/python_catalog.py 0.00% <0.00%> (ø)
src/daft-catalog/src/errors.rs 0.00% <0.00%> (ø)
daft/catalog/__init__.py 56.25% <56.25%> (ø)
daft/catalog/pyiceberg.py 0.00% <0.00%> (ø)
src/daft-catalog/src/python.rs 25.80% <25.80%> (ø)
daft/catalog/unity.py 0.00% <0.00%> (ø)
... and 2 more

... and 139 files with indirect coverage changes