Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Use table instead of micropartition for native executor #2939

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

colin-ho
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the chore label Sep 26, 2024
Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #2939 will not alter performance

Comparing colin/use-table-instead-of-mp (043b8c7) with main (edeee9e)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (a5cb55d) to head (e429fdd).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-local-execution/src/sources/in_memory.rs 0.00% 3 Missing ⚠️
src/daft-table/src/lib.rs 40.00% 3 Missing ⚠️
...aft-local-execution/src/intermediate_ops/buffer.rs 71.42% 2 Missing ⚠️
src/daft-json/src/read.rs 0.00% 1 Missing ⚠️
src/daft-micropartition/src/ops/pivot.rs 0.00% 1 Missing ⚠️
src/daft-micropartition/src/ops/sort.rs 0.00% 1 Missing ⚠️
src/daft-table/src/growable/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
- Coverage   78.37%   78.29%   -0.08%     
==========================================
  Files         596      602       +6     
  Lines       69688    71012    +1324     
==========================================
+ Hits        54616    55601     +985     
- Misses      15072    15411     +339     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/daft-csv/src/read.rs 99.33% <100.00%> (ø)
.../src/intermediate_ops/anti_semi_hash_join_probe.rs 95.74% <100.00%> (-0.62%) ⬇️
...-execution/src/intermediate_ops/hash_join_probe.rs 97.05% <100.00%> (-0.37%) ⬇️
...-execution/src/intermediate_ops/intermediate_op.rs 80.00% <ø> (ø)
src/daft-local-execution/src/pipeline.rs 91.44% <100.00%> (ø)
src/daft-local-execution/src/run.rs 90.15% <100.00%> (+0.30%) ⬆️
src/daft-local-execution/src/sinks/aggregate.rs 100.00% <ø> (ø)
...rc/daft-local-execution/src/sinks/blocking_sink.rs 69.01% <ø> (ø)
.../daft-local-execution/src/sinks/hash_join_build.rs 95.16% <100.00%> (-0.08%) ⬇️
src/daft-local-execution/src/sinks/limit.rs 100.00% <ø> (ø)
... and 18 more

... and 74 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant