-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] add list.value_counts()
#2902
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #2902 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2902 +/- ##
==========================================
- Coverage 66.33% 62.87% -3.47%
==========================================
Files 1004 1001 -3
Lines 114031 116662 +2631
==========================================
- Hits 75645 73353 -2292
- Misses 38386 43309 +4923
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b983578
to
ba181af
Compare
# todo: do we want type to be a Map expression? how should we do this? | ||
def value_counts(self) -> Expression: | ||
"""Counts the occurrences of each unique value in the list. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give example usage
a4e1c7b
to
e063b04
Compare
Co-authored-by: Jay Chia <[email protected]>
still a few things to do particular with types being null or not... but at least should not crash now