Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] add register-table helper to sql-catalog #2837

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chuanlei-coding
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Sep 12, 2024
Copy link

codspeed-hq bot commented Sep 12, 2024

CodSpeed Performance Report

Merging #2837 will degrade performances by 54.44%

Comparing chuanlei-coding:feat-add-register-table-helper-to-sqlcatalog (65d03ff) with main (c2d7d08)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chuanlei-coding:feat-add-register-table-helper-to-sqlcatalog Change
test_count[1 Small File] 10.6 ms 23.2 ms -54.44%
test_show[100 Small Files] 121.8 ms 65.4 ms +86.18%

@jaychia
Copy link
Contributor

jaychia commented Sep 15, 2024

Hi, what's the intended use-case/ticket that this would address?

cc @universalmind303 as well who is designing the overall story for SQL

@chuanlei-coding
Copy link
Contributor Author

@jaychia @universalmind303 so we can sql query dataframe on the fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants