Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add endpoints to simulate rate-limiting on AWS S3 buckets #1220

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Aug 2, 2023

Summary

Adds FastAPI endpoints for integration tests, simulating rate-limiting on AWS S3 buckets.

Drive-by: refactors our code to use FastAPI sub-apps instead of Routers. This is needed to enable better control around rate limiting per-"app", where each app corresponds to an S3 bucket with certain characteristics.

Closes: #1179

More work needs to be done here once we support customizable retry policies, so that we can verify that these retry strategies work.

@github-actions github-actions bot added the chore label Aug 2, 2023
@jaychia jaychia enabled auto-merge (squash) August 2, 2023 19:05
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1220 (f2dfbd4) into main (e95acae) will decrease coverage by 0.02%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
- Coverage   88.43%   88.41%   -0.02%     
==========================================
  Files          55       55              
  Lines        5620     5620              
==========================================
- Hits         4970     4969       -1     
- Misses        650      651       +1     

see 1 file with indirect coverage changes

@jaychia jaychia merged commit 60512a0 into main Aug 2, 2023
22 checks passed
@jaychia jaychia deleted the jay/rate-limited-bucket branch August 2, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IO] Stress test native Parquet reading
1 participant