[CHORE] Remove existing LogicalPlan from all execution concepts #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
- Coverage 88.41% 88.31% -0.11%
==========================================
Files 55 55
Lines 5620 5630 +10
==========================================
+ Hits 4969 4972 +3
- Misses 651 658 +7
|
added 2 commits
August 1, 2023 15:20
clarkzinzow
reviewed
Aug 1, 2023
daft/execution/execution_step.py
Outdated
| @@ -5,6 +5,8 @@ | |||
| from dataclasses import dataclass, field | |||
| from typing import Generic, TypeVar | |||
|
|
|||
| import fsspec | |||
There was a problem hiding this comment.
This should be behind a TYPE_CHECKING guard since fsspec is an optional dependency.
There was a problem hiding this comment.
thank you, done!
daft/execution/physical_plan.py
Outdated
| @@ -17,8 +17,10 @@ | |||
| from collections import deque | |||
| from typing import Generator, Iterator, TypeVar, Union | |||
|
|
|||
| import fsspec | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a lot of query fragment executors are parameterized by a LogicalPlan node object, since it holds relevant subfields. This is not necessary; the executors can be parameterized by the subfields directly.
This PR removes LogicalPlan from all query execution concepts.