Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add developer flag to use Rust query planner #1205

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

xcharleslin
Copy link
Contributor

@xcharleslin xcharleslin commented Aug 1, 2023

Setting: DAFT_DEVELOPER_RUST_QUERY_PLANNER=1

Retrieving: get_context().use_rust_planner -> bool

@github-actions github-actions bot added the chore label Aug 1, 2023
@xcharleslin xcharleslin marked this pull request as ready for review August 1, 2023 17:41
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1205 (18c7fea) into main (bd4235e) will increase coverage by 0.00%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1205   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          55       55           
  Lines        5617     5620    +3     
=======================================
+ Hits         4966     4969    +3     
  Misses        651      651           
Files Changed Coverage Δ
daft/context.py 80.55% <100.00%> (+0.84%) ⬆️

Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

daft/context.py Outdated Show resolved Hide resolved
Co-authored-by: Clark Zinzow <[email protected]>
@xcharleslin xcharleslin enabled auto-merge (squash) August 1, 2023 19:32
@xcharleslin xcharleslin merged commit 954788a into main Aug 1, 2023
18 checks passed
@xcharleslin xcharleslin deleted the charles/planflag branch August 1, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants