Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Exclude JSON pre-commit fixer for ipynb files #1184

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jul 24, 2023

For some reason this is only happening in CI but not locally, breaking our CI builds.

Let's disable this since ipynb files are not human-readable anyways.

@github-actions github-actions bot added the chore label Jul 24, 2023
@jaychia jaychia enabled auto-merge (squash) July 24, 2023 18:11
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1184 (11c687e) into main (6a36160) will not change coverage.
The diff coverage is n/a.

❗ Current head 11c687e differs from pull request most recent head 4919b29. Consider uploading reports for the commit 4919b29 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1184   +/-   ##
=======================================
  Coverage   88.43%   88.43%           
=======================================
  Files          54       54           
  Lines        5562     5562           
=======================================
  Hits         4919     4919           
  Misses        643      643           

@jaychia jaychia merged commit 355e494 into main Jul 24, 2023
16 checks passed
@jaychia jaychia deleted the jay/fix-style-ci branch July 24, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant