Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix remote mode typo #1092

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[BUG] Fix remote mode typo #1092

merged 1 commit into from
Jun 26, 2023

Conversation

xcharleslin
Copy link
Contributor

@xcharleslin xcharleslin commented Jun 26, 2023

Verified fix on local ray cluster via ray client

@github-actions github-actions bot added the bug Something isn't working label Jun 26, 2023
@xcharleslin xcharleslin marked this pull request as ready for review June 26, 2023 17:50
@xcharleslin xcharleslin enabled auto-merge (squash) June 26, 2023 17:50
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1092 (9e48f0b) into main (31a1b94) will decrease coverage by 0.41%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   88.87%   88.46%   -0.41%     
==========================================
  Files          53       54       +1     
  Lines        5439     5463      +24     
==========================================
- Hits         4834     4833       -1     
- Misses        605      630      +25     
Impacted Files Coverage Δ
daft/runners/ray_runner.py 92.09% <0.00%> (ø)

... and 5 files with indirect coverage changes

@xcharleslin xcharleslin merged commit 9063395 into main Jun 26, 2023
17 of 18 checks passed
@xcharleslin xcharleslin deleted the charles/fix-scheduler-actor branch June 26, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant