Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Enable Native Downloader IO Config #1090

Merged
merged 7 commits into from
Jun 23, 2023
Merged

[FEAT] Enable Native Downloader IO Config #1090

merged 7 commits into from
Jun 23, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Jun 23, 2023 •
edited
Loading

  • Allows for S3 configuration for Native Downloader

@samster25 samster25 changed the title Sammy/s3 io config [FEAT] Enable Native Downloader IO Config Jun 23, 2023
@github-actions github-actions bot added the enhancement New feature or request label Jun 23, 2023
@samster25 samster25 enabled auto-merge (squash) June 23, 2023 23:09
@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #1090 (cce90c7) into main (e101ed6) will increase coverage by 0.11%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   88.35%   88.46%   +0.11%     
==========================================
  Files          54       54              
  Lines        5477     5463      -14     
==========================================
- Hits         4839     4833       -6     
+ Misses        638      630       -8
Impacted Files Coverage Δ
daft/series.py 92.53% <ø> (+2.45%) ⬆️
daft/expressions/expressions.py 91.56% <66.66%> (-0.26%) ⬇️
daft/io/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@samster25 samster25 merged commit cb1bf51 into main Jun 23, 2023
@samster25 samster25 deleted the sammy/s3-io-config branch June 23, 2023 23:23
@samster25
Copy link
Member Author

closes: #1071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samster25