Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reenable HTML viz hooks for np.ndarray and PIL Images #1078

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jun 22, 2023

Closes: #1077 and #1075

  • Adds a fix for Series.from_pylist(..., pyobj="force") when the list is a list of PIL Images (cc @clarkzinzow)
  • Re-enables our HTML viz hooks in Python, for Python objects when calling into the HTML repr for Python arrays

@jaychia jaychia force-pushed the jay/reenable-PIL-python-image-display branch from 41cd4cb to c167ef8 Compare June 22, 2023 00:12
@github-actions github-actions bot added the bug Something isn't working label Jun 22, 2023
@jaychia jaychia enabled auto-merge (squash) June 22, 2023 00:49
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1078 (129d436) into main (1c49647) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
+ Coverage   88.64%   88.85%   +0.20%     
==========================================
  Files          54       54              
  Lines        5382     5382              
==========================================
+ Hits         4771     4782      +11     
+ Misses        611      600      -11     
Impacted Files Coverage Δ
daft/series.py 90.08% <100.00%> (ø)
daft/viz/html_viz_hooks.py 84.61% <100.00%> (+28.20%) ⬆️

@jaychia jaychia merged commit 1c41ad8 into main Jun 22, 2023
15 checks passed
@jaychia jaychia deleted the jay/reenable-PIL-python-image-display branch June 22, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a Series of Python objects does not work for PIL Images
1 participant