[BUG] Better List type repr in dataframes Fixes#994 #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of local op name
…tion of local op name
khandelwalarvind26
changed the title
khandelwalarvind26
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
- Coverage 88.46% 88.46% -0.01%
==========================================
Files 54 54
Lines 5463 5462 -1
==========================================
- Hits 4833 4832 -1
Misses 630 630
|
|
Thanks @khandelwalarvind26! I am a little concerned that removing the intermediate column name might affect the results of the query. Could we not modify the repr logic of the List type directly instead to just not display the child type (as per: #994)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the intermediate column name and directly uses the result column name which skips the addition of the child field name such as _local_list in the case of list aggregations. This completely omits the display of the local op performed.