Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] [Images] [9/N] Infer Image type for PIL images on ingress. #1067

Merged
merged 7 commits into from
Jun 21, 2023
Merged

[FEAT] [Images] [9/N] Infer Image type for PIL images on ingress. #1067

merged 7 commits into from
Jun 21, 2023

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Jun 20, 2023 •
edited
Loading

This PR infers the Image type for PIL images provided to Series.from_pylist(), and therefore for Table.from_pydict() and DataFrame.from_pydict().

@github-actions github-actions bot added the enhancement New feature or request label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Merging #1067 (2a876ce) into main (64ab8ce) will decrease coverage by 43.97%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1067       +/-   ##
===========================================
- Coverage   84.78%   40.82%   -43.97%     
===========================================
  Files         187      181        -6     
  Lines       17177    15392     -1785     
===========================================
- Hits        14564     6284     -8280     
- Misses       2613     9108     +6495
Impacted Files Coverage Δ
src/array/ops/cast.rs 20.13% <ø> (-70.18%) ⬇️
src/datatypes/image_mode.rs 0.00% <0.00%> (-41.35%) ⬇️

... and 135 files with indirect coverage changes

jaychia
jaychia reviewed Jun 20, 2023
View reviewed changes
src/python/series.rs Outdated Show resolved Hide resolved
@clarkzinzow clarkzinzow requested a review from jaychia June 20, 2023 23:31
samster25
samster25 approved these changes Jun 21, 2023
View reviewed changes
src/python/series.rs Outdated Show resolved Hide resolved
src/python/series.rs Outdated Show resolved Hide resolved
src/python/series.rs Outdated Show resolved Hide resolved
@clarkzinzow clarkzinzow merged commit 6d1feb7 into main Jun 21, 2023
13 of 15 checks passed
@clarkzinzow clarkzinzow deleted the clark/ingress-image-inference branch June 21, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samster25 samster25 samster25 approved these changes

@jaychia jaychia Awaiting requested review from jaychia

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clarkzinzow @samster25 @jaychia