[FEAT] New DataType: Duration (without arithmetic) #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 88.65% 88.66% +0.01%
==========================================
Files 54 54
Lines 5375 5382 +7
==========================================
+ Hits 4765 4772 +7
Misses 610 610
|
added 11 commits
June 14, 2023 17:47
xcharleslin
changed the title
samster25
approved these changes
Jun 16, 2023
src/array/ops/filter.rs
Outdated
| let new_array = self.physical.filter(mask)?; | ||
| Ok(Self::new(self.field.clone(), new_array)) | ||
| } | ||
| macro_rules! impl_logical_array_filter { |
There was a problem hiding this comment.
Since all of these are the same, what do you think of putting it into the logicalarray impl https://github.com/Eventual-Inc/Daft/blob/main/src/datatypes/logical.rs#L15
| let new_array = self.physical.if_else(&other.physical, predicate)?; | ||
| Ok(Self::new(self.field.clone(), new_array)) | ||
| } | ||
| macro_rules! impl_logicalarray_if_else { |
There was a problem hiding this comment.
Same thing as filter: thoughts on moving this to logicalarray impl: https://github.com/Eventual-Inc/Daft/blob/main/src/datatypes/logical.rs#L15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for an Arrow-like Duration datatype in Daft, parameterized by TimeUnit.
Includes: conversion to/from Arrow, Python; casting (using Arrow logical->logical casts); blackbox kernels.
Does not include temporal arithmetic, which requires refactoring the type system (next PR).
Drivebys
Converted various Array ops to macros.