Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Scheduler cleanup: merge logical_op_runners.py into execution_step #1020

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[CHORE] Scheduler cleanup: merge logical_op_runners.py into execution_step #1020

merged 1 commit into from
Jun 22, 2023

Conversation

xcharleslin
Copy link
Contributor

No description provided.

@xcharleslin xcharleslin marked this pull request as ready for review June 8, 2023 02:31
@xcharleslin xcharleslin enabled auto-merge (squash) June 8, 2023 02:31
@xcharleslin xcharleslin enabled auto-merge (squash) June 22, 2023 18:45
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@eb7e2c8). Click here to learn what that means.
The diff coverage is 97.50%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage        ?   88.87%           
=======================================
  Files           ?       53           
  Lines           ?     5439           
  Branches        ?        0           
=======================================
  Hits            ?     4834           
  Misses          ?      605           
  Partials        ?        0
Impacted Files Coverage Δ
daft/runners/pyrunner.py 94.67% <ø> (ø)
daft/execution/execution_step.py 94.07% <97.50%> (ø)

@xcharleslin xcharleslin merged commit cd59693 into main Jun 22, 2023
14 of 15 checks passed
@xcharleslin xcharleslin deleted the charles/logicaloprunner branch June 22, 2023 18:56
@xcharleslin xcharleslin changed the title Scheduler cleanup: merge logical_op_runners.py into execution_step [CHORE] Scheduler cleanup: merge logical_op_runners.py into execution_step Jun 22, 2023
@github-actions github-actions bot added the chore label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xcharleslin