Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO] S3 Config to incorporate STS assume role credentials for parquet reader #1216

Closed
raghumdani opened this issue Aug 2, 2023 · 0 comments · Fixed by #1224
Closed

[IO] S3 Config to incorporate STS assume role credentials for parquet reader #1216

raghumdani opened this issue Aug 2, 2023 · 0 comments · Fixed by #1224
Assignees

Comments

@raghumdani
Copy link

Is your feature request related to a problem? Please describe.
We would like to use daft.read_parquet method due to it's efficiency. However, we our files are access via STS assume role credentials from S3. There is an io_config=S3Config we can specify to set access key to use for S3 access, however I see session_token missing.

Describe the solution you'd like
The session_token can be added to S3 Config:

pub struct S3Config {
    pub region_name: Option<String>,
    pub endpoint_url: Option<String>,
    pub key_id: Option<String>,
    pub access_key: Option<String>,
    pub session_token: Option<String>,
    pub anonymous: bool,
}

Describe alternatives you've considered

  • Setting environment variables is not ideal because each file is accessed with different credentials in most cases which would break in a distributed environment.

Additional context
Add any other context or screenshots about the feature request here.

@jaychia jaychia added this to Daft-OSS Aug 2, 2023
@jaychia jaychia moved this to In progress in Daft-OSS Aug 2, 2023
@samster25 samster25 linked a pull request Aug 2, 2023 that will close this issue
samster25 added a commit that referenced this issue Aug 3, 2023
* Adds `session_token` field to `S3Config` allowing users to pass temp
session tokens (like from sts)to daft.
* Adds IO integration tests to ensure that we can use the IOConfig to
access s3 with a signed request.
* Closes: #1216
@jaychia jaychia moved this from In progress to Done in Daft-OSS Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants