Skip to content

Commit

Permalink
Remove secret from composite action and pass it as an input instead
Browse files Browse the repository at this point in the history
  • Loading branch information
raunakab committed Nov 16, 2024
1 parent d442453 commit ccff831
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/actions/build-commit/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Build a specific daft commit and store it in AWS S3
description: Build a specific daft commit and store the output wheel in AWS S3

inputs:
aws_role_arn:
description: The ARN of the AWS role to assume
required: true
commit:
description: The commit hash to build
required: true
Expand All @@ -18,7 +21,7 @@ runs:
uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: us-west-2
role-to-assume: ${{ secrets.ACTIONS_AWS_ROLE_ARN }}
role-to-assume: ${{ inputs.aws_role_arn }}
role-session-name: daft-performance-comparisons-build
- name: Checkout commit ${{ inputs.commit }}
uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/benchmark-local.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
ref: ${{ matrix.commit }}
- uses: ./.github/actions/build-commit
with:
aws_role_arn: ${{ secrets.ACTIONS_AWS_ROLE_ARN }}
commit: ${{ matrix.commit }}

# - name: Assume AWS credentials
Expand Down

0 comments on commit ccff831

Please sign in to comment.