Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote update feature #1060

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

LocutusOfBorg
Copy link
Contributor

No description provided.

@LocutusOfBorg
Copy link
Contributor Author

This was left over in 47638bd #164

@LocutusOfBorg LocutusOfBorg changed the title Update Update remote feature Jul 17, 2020
@LocutusOfBorg LocutusOfBorg changed the title Update remote feature remote update feature Jul 17, 2020
@koeppea
Copy link
Member

koeppea commented Jul 19, 2020

Hi Franky,
this is impressive.
What do you think about the suggestion from @eascob to use libcurl for this functionality?

@LocutusOfBorg
Copy link
Contributor Author

I see @eaescob doing something similar on his repo, I'm still not that good at writing code :)
but I might try if nobody does it!

@eaescob
Copy link
Contributor

eaescob commented Jul 21, 2020

This is awesome! Yeah, libcurl just looks cleaner (IMO). Let me see if I can take a stab at it based on what you've written. Regarding the fingerprints, can you two please look at my question posted in #1058 ?

[ 51%] Building C object src/CMakeFiles/lib_ettercap.dir/dissectors/ec_ssh.c.o

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:560:52: error:

      variable 'm_h_n' is uninitialized when used here [-Werror,-Wuninitialized]

            temp_session_id=ssh_session_id(cookie, m_h_n, m_s_n);

                                                   ^~~~~

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:146:29: note:

      initialize the variable 'm_h_n' to silence this warning

   BIGNUM *h_n, *s_n, *m_h_n, *m_s_n;

                            ^

                             = NULL

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:560:59: error:

      variable 'm_s_n' is uninitialized when used here [-Werror,-Wuninitialized]

            temp_session_id=ssh_session_id(cookie, m_h_n, m_s_n);

                                                          ^~~~~

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:146:37: note:

      initialize the variable 'm_s_n' to silence this warning

   BIGNUM *h_n, *s_n, *m_h_n, *m_s_n;

                                    ^

                                     = NULL

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:552:54: error:

      variable 'h_n' is uninitialized when used here [-Werror,-Wuninitialized]

            temp_session_id = ssh_session_id(cookie, h_n, s_n);

                                                     ^~~

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:146:15: note:

      initialize the variable 'h_n' to silence this warning

   BIGNUM *h_n, *s_n, *m_h_n, *m_s_n;

              ^

               = NULL

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:552:59: error:

      variable 's_n' is uninitialized when used here [-Werror,-Wuninitialized]

            temp_session_id = ssh_session_id(cookie, h_n, s_n);

                                                          ^~~

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:146:21: note:

      initialize the variable 's_n' to silence this warning

   BIGNUM *h_n, *s_n, *m_h_n, *m_s_n;

                    ^

                     = NULL

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:398:64: error:

      variable 's_d' is uninitialized when used here [-Werror,-Wuninitialized]

               RSA_set0_key(session_data->serverkey, s_n, s_e, s_d);

                                                               ^~~

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:148:21: note:

      initialize the variable 's_d' to silence this warning

   BIGNUM *h_d, *s_d, *m_h_d, *m_s_d;

                    ^

                     = NULL

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:409:62: error:

      variable 'h_d' is uninitialized when used here [-Werror,-Wuninitialized]

               RSA_set0_key(session_data->hostkey, h_n, h_e, h_d);

                                                             ^~~

/home/travis/build/Ettercap/ettercap/src/dissectors/ec_ssh.c:148:15: note:

      initialize the variable 'h_d' to silence this warning

   BIGNUM *h_d, *s_d, *m_h_d, *m_s_d;

              ^

               = NULL

6 errors generated.

make[2]: *** [src/CMakeFiles/lib_ettercap.dir/build.make:1197: src/CMakeFiles/lib_ettercap.dir/dissectors/ec_ssh.c.o] Error 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants