Fetch the hotshot liveness instead of inferring it #171
+35
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImJeremyHe
requested review from
nomaxg,
alysiahuggins,
zacshowa,
Sneh1999,
sveitser and
jbearer
as code owners
Sneh1999
reviewed
Jul 29, 2024
staker/block_validator.go
Outdated
| var isHotShotLive bool | ||
| isHotShotLive, err := v.lightClientReader.IsHotShotLive(msg.Message.Header.BlockNumber) | ||
| if err != nil { | ||
| return false, fmt.Errorf("error fetching the hotshot liveness") |
There was a problem hiding this comment.
nit: I think we should also attach the error here like - fmt.Errorf("error fetching the hotshot liveness: %v", err)
Sneh1999
reviewed
Jul 29, 2024
ImJeremyHe
force-pushed
the
jh/fix-validator
branch
from
e35ef9b
to
e60c027
Compare
ImJeremyHe
force-pushed
the
jh/fix-validator
branch
from
e60c027
to
eed2ff0
Compare
For now, the validators will just retry it again and again since there is a periodic task. The hotshot livenesses are stored in the L1 so I think there should not be a large probability that we failed to get it. |
Sneh1999
approved these changes
Aug 2, 2024
ImJeremyHe
force-pushed
the
jh/fix-validator
branch
from
2c7422e
to
320c73f
Compare
ImJeremyHe
force-pushed
the
jh/fix-validator
branch
from
320c73f
to
fd7db10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Validators will not infer the hotshot liveness from the messages. It would fetch the hotshot liveness from the hotshot light client contract.
This provides the STF the correct information to check the hotshot liveness.