Add exact calculation of encoded transaction size #195
+55
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11509179894Details
💛 - Coveralls |
shenkeyao
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Just make sure to replace the branch with the new HotShot tag.
Comment on lines
+1455
to
+1458
| const NS_ID_BYTE_LEN: usize = 4; | ||
| const NS_OFFSET_BYTE_LEN: usize = 4; | ||
| const NUM_TXS_BYTE_LEN: usize = 4; | ||
| const TX_OFFSET_BYTE_LEN: usize = 4; |
There was a problem hiding this comment.
These look good to me, but we may want to remove the duplicate definitions in the sequencer repo, so that the sequencer will import these values from the builder repo, to avoid inconsistency.
Comment on lines
+1555
to
+1556
| /// A const number on `max_tx_len` to be used consistently spanning all the tests | ||
| const TEST_MAX_TX_LEN: u64 = 20; |
There was a problem hiding this comment.
Double-checking how we get 20--is it length 4 + overhead 16? Can you add a comment here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169
This PR:
This PR does not:
Key places to review: