-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exact calculation of encoded transaction size #195
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 11509179894Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make sure to replace the branch with the new HotShot tag.
const NS_ID_BYTE_LEN: usize = 4; | ||
const NS_OFFSET_BYTE_LEN: usize = 4; | ||
const NUM_TXS_BYTE_LEN: usize = 4; | ||
const TX_OFFSET_BYTE_LEN: usize = 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me, but we may want to remove the duplicate definitions in the sequencer repo, so that the sequencer will import these values from the builder repo, to avoid inconsistency.
/// A const number on `max_tx_len` to be used consistently spanning all the tests | ||
const TEST_MAX_TX_LEN: u64 = 20; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-checking how we get 20
--is it length 4
+ overhead 16
? Can you add a comment here?
Closes #169
This PR:
This PR does not:
Key places to review: