-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune dependencies #3787
base: main
Are you sure you want to change the base?
Prune dependencies #3787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me overall, really like the cleanup!
approving, but I think it would be worth having someone else look at the U256
crate change
@@ -21,6 +21,6 @@ pub trait ToFields<F: Field> { | |||
/// convert a U256 to a field element. | |||
pub(crate) fn u256_to_field<F: PrimeField>(v: &U256) -> F { | |||
let mut bytes = vec![0u8; 32]; | |||
v.to_little_endian(&mut bytes); | |||
v.write_as_little_endian(&mut bytes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like the same thing to me, though I'm not really familiar with either crate. is the U256
the same rust type?
it might be worth having someone else (@alxiong ?) confirm this is fine/won't affect downstream repos etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context: eth-types and primitive-types live in the same repo
The reason for the diff is they've recently updated the names for these methods recently which wasn't yet reflected in our eth-types version
Closes #<ISSUE_NUMBER>
This PR:
custom_debug
andderivative
in favor ofderive_more
(we've been using all three,derive_more
covers all use-cases)mnemonic
function from cdn-proto to hotshot-types, as it's quite simple and depending oncdn-proto
only for this function pulled in a lot of unused dependenciesethereum-types
when we actually use onlyU256
that it re-exports from smallerprimitive-types
)This PR does not:
Key places to review: