Update view sync for 2 timeouts #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenkeyao
reviewed
Dec 14, 2023
Comment on lines
+748
to
+751
| error!( | ||
| "View sync protocol has received view sync evidence to update the view to {}", | ||
| *self.next_view | ||
| ); |
There was a problem hiding this comment.
I think the logging at lines 475 and 484 should suffice?
There was a problem hiding this comment.
My thought here was to log when view sync successfully updates the view, as well as when it starts. So we can see if view sync is updating the view or if the view is updated because a proposal was received.
shenkeyao
previously approved these changes
Dec 14, 2023
bfish713
previously approved these changes
Dec 14, 2023
elliedavidson
dismissed stale reviews from bfish713 and shenkeyao
via
b094cf0
shenkeyao
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: