Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Committable from more types #1792

Merged
merged 6 commits into from
Sep 21, 2023
Merged

chore: Remove Committable from more types #1792

merged 6 commits into from
Sep 21, 2023

Conversation

ggutoski
Copy link
Contributor

fix #1791

Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to push more commits and I'll review them!

@ggutoski ggutoski merged commit 6f85c10 into main Sep 21, 2023
6 checks passed
@ggutoski ggutoski deleted the gg/1791 branch September 21, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T2.1.4: Remove Committable from type params for a bunch more types
2 participants