Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove Committable from VoteData type param #1779

Merged
merged 2 commits into from
Sep 19, 2023
Merged

chore: remove Committable from VoteData type param #1779

merged 2 commits into from
Sep 19, 2023

Conversation

ggutoski
Copy link
Contributor

fix #1778

Also, fix libp2p examples build break.

@ggutoski
Copy link
Contributor Author

CI again this is a new one:

LLVM ERROR: IO failure on output stream: No space left on device
error: could not compile hotshot-task (lib test)

Tests pass locally. Merging despite CI.

@ggutoski ggutoski merged commit 028b688 into main Sep 19, 2023
4 of 6 checks passed
@ggutoski ggutoski deleted the gg/1778 branch September 19, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenkeyao shenkeyao shenkeyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

T2.1.2: VoteData type param should not be Committable
2 participants
@ggutoski @shenkeyao